[GraphExecutor] Add API get_input_info to graph_executor
#9889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeexyz
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
leandron,
liangfu,
masahi,
merrymercy,
tmoreau89,
tqchen,
vinx13,
yzhliu,
zhiics and
ZihengJiang
as code owners
leeexyz
changed the title
get_input_info to graph_executorget_input_info to graph_executor
masahi
approved these changes
Jan 13, 2022
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
Raghav-Chakravarthy
pushed a commit
to Raghav-Chakravarthy/tvm
that referenced
this pull request
Jan 28, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
ghost
mentioned this pull request
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Jun 17, 2022
As described in apache#11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after apache#9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a unit test has been provided to help prevent this regression in the future. Change-Id: I70c1863d00098270e27c08ba834a3587e9132d69
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Jun 17, 2022
As described in apache#11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after apache#9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a test has been provided to help prevent this regression in the future. Change-Id: I70c1863d00098270e27c08ba834a3587e9132d69
leandron
pushed a commit
that referenced
this pull request
Jun 20, 2022
* [TVMC] Fix tvmc run when using rpc As described in #11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after #9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a test has been provided to help prevent this regression in the future. Change-Id: I70c1863d00098270e27c08ba834a3587e9132d69 * fix lint Change-Id: I958cf4e19988d047bdd2e02f6475b9f70afe80c8
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Jun 21, 2022
* [TVMC] Fix tvmc run when using rpc As described in apache#11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after apache#9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a test has been provided to help prevent this regression in the future. Change-Id: I70c1863d00098270e27c08ba834a3587e9132d69 * fix lint Change-Id: I958cf4e19988d047bdd2e02f6475b9f70afe80c8
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* [TVMC] Fix tvmc run when using rpc As described in apache#11707, the RPC mechanism does not support objects of type Map which breaks the use of tvmc run when using RPC after apache#9889. This commit intends to workaround this issue by providing a fallback to the old implementation when RPC is being used. Further, a test has been provided to help prevent this regression in the future. Change-Id: I70c1863d00098270e27c08ba834a3587e9132d69 * fix lint Change-Id: I958cf4e19988d047bdd2e02f6475b9f70afe80c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
In the GraphExecutor use case, we always should get the input info of a compiled graph module, including shape and dtype. For
TVMC, it provides get_input_info to get and then to generate the input data. But it is inconvenient if we only deploy the CPP runtime because there is no graph info to be exposed outside of GraphExecutor, and it is very cumbersome to load and parse the Graph JSON again. So here I move theget_input_infofunction into GraphExecutor, then we can easily write a make_inputs_dict function on the CPP side.