-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUTLASS] Support more kernels: int8, tf32, and 3xtf32 #9899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
manupak and
MarisaKirisame
as code owners
January 11, 2022 06:31
masahi
requested review from
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
January 11, 2022 06:31
comaniac
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. LGTM.
Thanks @masahi |
@masahi, cutlass profiler misses many 256x64, 64x256 tile sizes for turing/volta kernels. It needs some change like
Also, cutlass works the best with cuda 11.3+. |
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
* add int8 type in library * wip * adding test and plumbing data and weight dtype * adding 3xtf32 support and refactor tile description enum * add 3xtf32 test * update gemm generator too * int8 test worked * 3xtf32 also works * int8 and 3xtf32 gemm works * clean up test * support int8 in sm75 * refined int8 alignment constraints * black * support 3xtf32 in default kernel * remove log * refine dtype check * support tf32 * leave TODO for alignment modification on int8 kernels * tf32 test working * fix default kernel for tf32 * workaround for compilation failure * lint
Raghav-Chakravarthy
pushed a commit
to Raghav-Chakravarthy/tvm
that referenced
this pull request
Jan 28, 2022
* add int8 type in library * wip * adding test and plumbing data and weight dtype * adding 3xtf32 support and refactor tile description enum * add 3xtf32 test * update gemm generator too * int8 test worked * 3xtf32 also works * int8 and 3xtf32 gemm works * clean up test * support int8 in sm75 * refined int8 alignment constraints * black * support 3xtf32 in default kernel * remove log * refine dtype check * support tf32 * leave TODO for alignment modification on int8 kernels * tf32 test working * fix default kernel for tf32 * workaround for compilation failure * lint
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* add int8 type in library * wip * adding test and plumbing data and weight dtype * adding 3xtf32 support and refactor tile description enum * add 3xtf32 test * update gemm generator too * int8 test worked * 3xtf32 also works * int8 and 3xtf32 gemm works * clean up test * support int8 in sm75 * refined int8 alignment constraints * black * support 3xtf32 in default kernel * remove log * refine dtype check * support tf32 * leave TODO for alignment modification on int8 kernels * tf32 test working * fix default kernel for tf32 * workaround for compilation failure * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@comaniac @Laurawly @hwu36
The change is mostly boilerplate. Supports int8, tf32, and 3xtf32 for both gemm and conv2d. TF32 and 3xtf32 are meant for training and not expected to be fast on Geforce cards (see NVIDIA/cutlass#390). But I found that
atol = rtol = 1e-5
).For int8, I tested on quantized resnet50. But for some reason, the performance is worse than fp16. I haven't investigated deeply yet. In general, int8 models available for benchmarking are quite limited.