Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Fix build issue due to #9611 #9914

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

mehrdadh
Copy link
Member

This PR reverts tvm_file_glob change in HexagonSDK file since this function is supposed to be used on tvm files.

@mehrdadh
Copy link
Member Author

cc @tkonolige

Copy link
Contributor

@tkonolige tkonolige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mehrdadh!

@kparzysz-quic
Copy link
Contributor

I already have a PR with a fix: #9903

@masahi
Copy link
Member

masahi commented Jan 13, 2022

Merged #9903

@masahi masahi closed this Jan 13, 2022
@tkonolige
Copy link
Contributor

@masa #9903 does not fully fix the issue. We should not be using tvm_file_glob on anything outside of the tvm codebase. Can you re-open and merge this PR?

@masahi masahi reopened this Jan 13, 2022
@masahi
Copy link
Member

masahi commented Jan 13, 2022

Sorry!!

@masahi masahi self-assigned this Jan 13, 2022
@masahi masahi merged commit 220b122 into apache:main Jan 14, 2022
@mehrdadh mehrdadh deleted the fix_hexagon_build branch January 14, 2022 17:19
AndrewZhaoLuo added a commit that referenced this pull request Jan 14, 2022
…ker-staging

* 'ci-docker-staging' of github.com:apache/tvm:
  upgrade to latest images
  fix missing - with _
  swtich to proper repo for docker
  formatting
  jenkinsfile and one test
  Restore the use of ONNX_DEFAULT_CONFIGS["use_nt_batch_matmul"] (#9925)
  Fix HexagonSDK.cmake (#9914)
  fix icelake target for avx512 and vnni (#9928)
crazydemo pushed a commit to crazydemo/tvm that referenced this pull request Jan 27, 2022
Raghav-Chakravarthy pushed a commit to Raghav-Chakravarthy/tvm that referenced this pull request Jan 28, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants