Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-3003] Don't consider already preempted allocations for preemption #1006

Closed
wants to merge 2 commits into from
Closed

[YUNIKORN-3003] Don't consider already preempted allocations for preemption #1006

wants to merge 2 commits into from

Conversation

psantacl
Copy link
Contributor

What is this PR for?

We should not consider previously preempted allocations as potential victims for future preemptions.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-3003

How should this be tested?

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

craigcondit
craigcondit requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, but fix lint issues, and remove the unnecessary UnmarkPreempted() function.

@craigcondit craigcondit changed the title YUNIKORN-3003 [YUNIKORN-3003] Don't consider already allocations tasks for preemption Dec 19, 2024
@craigcondit craigcondit changed the title [YUNIKORN-3003] Don't consider already allocations tasks for preemption [YUNIKORN-3003] Don't consider already allocations for preemption Dec 19, 2024
@craigcondit craigcondit changed the title [YUNIKORN-3003] Don't consider already allocations for preemption [YUNIKORN-3003] Don't consider already preempted allocations for preemption Dec 19, 2024
craigcondit
craigcondit approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

craigcondit pushed a commit that referenced this pull request Dec 19, 2024
@psantacl @craigcondit
[YUNIKORN-3003] Don't consider already preempted allocations for pree…
8c9247a 
…mption (#1006)

Closes: #1006

Signed-off-by: Craig Condit <[email protected]>
rhh777 pushed a commit to rhh777/yunikorn-core that referenced this pull request Dec 25, 2024
@psantacl @rhh777
[YUNIKORN-3003] Don't consider alreadyy preempted allocations for pre…
c44969d 
…emption (apache#1006)

Closes: apache#1006

Signed-off-by: Craig Condit <[email protected]>
(cherry picked from commit 4d50a5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcondit craigcondit craigcondit approved these changes

@wilfred-s wilfred-s Awaiting requested review from wilfred-s

@pbacsko pbacsko Awaiting requested review from pbacsko

Assignees

@psantacl psantacl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psantacl @craigcondit