Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2044] remove GetQueueInfo function #676

Closed
wants to merge 2 commits into from

Conversation

steinsgateted
Copy link
Contributor

@steinsgateted steinsgateted commented Oct 15, 2023

What is this PR for?

1
remove GetQueueInfo function
2
PartitionQueueDAOInfo
Change to lowercase:
partitionQueueDAOInfo

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-2044

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #676 (b1c0c4b) into master (63f9731) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   77.71%   77.69%   -0.02%     
==========================================
  Files          79       79              
  Lines       13113    13089      -24     
==========================================
- Hits        10191    10170      -21     
+ Misses       2597     2594       -3     
  Partials      325      325              
Files Coverage Δ
pkg/scheduler/objects/queue.go 77.54% <ø> (-0.36%) ⬇️
pkg/scheduler/partition.go 78.27% <0.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@steinsgateted steinsgateted self-assigned this Oct 15, 2023
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s closed this in e032c2f Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants