[YUNIKORN-2052] Logging Enhancement for Preemption #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manirajv06
requested changes
Oct 20, 2023
pkg/scheduler/objects/preemption.go
Outdated
| zap.Stringer("resources", victim.GetAllocatedResource()), | ||
| zap.String("askApplicationID", p.ask.applicationID), | ||
| zap.String("askAllocationKey", p.ask.allocationKey), | ||
| zap.String("askQueue", p.ask.String()), |
There was a problem hiding this comment.
Instead of p.ask.String(), it should be p.queue.
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
=======================================
Coverage 77.69% 77.70%
=======================================
Files 79 79
Lines 13089 13095 +6
=======================================
+ Hits 10170 10175 +5
- Misses 2594 2595 +1
Partials 325 325
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wilfred-s
requested changes
Oct 20, 2023
manirajv06
approved these changes
Oct 20, 2023
|
@wilfred-s Do you have anymore comments? |
rrajesh-cloudera
changed the title
manirajv06
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging Enhancement for Preemption Logs
Newly Added fields in the Preemption Logs
Also, rename a few of the existing output items:
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2052