Adaptive BAL #330
Merged
Adaptive BAL #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
pre-commit.ci autofix |
Tetracarbonylnickel
requested changes
Sep 17, 2024
Comment on lines
-123
to
+161
| if self.return_raw: | ||
| if self.strategy == "raw": | ||
| (gb, gw), _ = jax.tree_util.tree_flatten(g_ll) | ||
|
|
||
| # g: n_atoms, 3, n_features | ||
| g = gw[:, :, :, 0] | ||
| else: | ||
| g_flat = jax.tree_map( | ||
| elif self.strategy == "sum": | ||
| g_summed = jax.tree_map( | ||
| lambda arr: jnp.reshape(jnp.sum(jnp.sum(arr, 0), 0), (-1,)), g_ll | ||
| ) | ||
| (gb, gw), _ = jax.tree_util.tree_flatten(g_flat) | ||
| (gb, gw), _ = jax.tree_util.tree_flatten(g_summed) | ||
| g = [gw, gb] | ||
| g = jnp.concatenate(g) | ||
|
|
||
| elif self.strategy == "flatten": | ||
| g_flat = jax.tree_map(lambda arr: jnp.reshape(arr, (-1,)), g_ll) | ||
| (gb, gw), _ = jax.tree_util.tree_flatten(g_flat) | ||
| g = gw | ||
| else: | ||
| raise ValueError(f"unknown strategy: {self.strategy}") |
There was a problem hiding this comment.
Maybe doing that like:
def raw():
.
.
.
strategies = {"raw": raw}
.
.
.
if strategy in strategies:
g = strategies[strategy](g_ll)
There was a problem hiding this comment.
the implementations of the different options is 19 lines of code, I don't think further abstraction is required.
Tetracarbonylnickel
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few features: