Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flax and ipsuite tests #391

Merged
merged 35 commits into from
Jan 20, 2025
Merged

update flax and ipsuite tests #391

merged 35 commits into from
Jan 20, 2025

Conversation

M-R-Schaefer
Copy link
Contributor

@M-R-Schaefer M-R-Schaefer commented Dec 17, 2024

originally, this PR was just an update of the ipsuite tests to be compatible with the newest versions and to update the flax version.
Due to complications with poetry, I have now also switched the project from poetry to uv.

Copy link
Contributor

@PythonFZ PythonFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, I have not tested it locally yet.

pyproject.toml Outdated Show resolved Hide resolved
@@ -41,24 +41,29 @@ You can then clone and install the project.

git clone https://github.com/apax-hub/apax.git <dest_dir>
cd <dest_dir>
poetry install
uv sync --all-extras --no-extra cuda
Copy link
Contributor

@Tetracarbonylnickel Tetracarbonylnickel Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add
To use the Installed packages, scripts are executed via uv run ...

See the [Jax installation instructions](https://github.com/google/jax#installation) for more details.


For more detailed instructions, please refer to the [documentation](https://apax.readthedocs.io/en/latest/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add "and dev installation"

@M-R-Schaefer M-R-Schaefer merged commit 86ba865 into main Jan 20, 2025
2 checks passed
@M-R-Schaefer M-R-Schaefer deleted the update_jax branch January 20, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants