Fix linter errors

ddp-redux/.eslintrc.json

@@ -1,7 +1,9 @@
 {
   "extends": "airbnb",
   "rules": {
-    "import/prefer-default-export": "off"
+    "import/prefer-default-export": "off",
+    "import/extensions": "off",
+    "max-len": ["error", 140]
   },
   "parser": "babel-eslint",
   "parserOptions": {

ddp-redux/package.json

@@ -9,6 +9,7 @@
     "coverage": "jest --coverage",
     "build": "babel src/ -d lib/",
     "build-watch": "watch 'npm run build' ./src",
+    "lint": "eslint src/",
     "prepublish": "npm run build"
   },
   "repository": {
@@ -38,11 +39,11 @@
     "babel-preset-stage-3": "^6.24.1",
     "chai": "^4.1.2",
     "eslint": "^4.19.1",
-    "eslint-config-airbnb": "^15.1.0",
+    "eslint-config-airbnb": "^16.1.0",
     "eslint-import-resolver-meteor": "^0.4.0",
     "eslint-plugin-import": "^2.12.0",
-    "eslint-plugin-jsx-a11y": "^5.1.1",
-    "eslint-plugin-react": "^7.1.0",
+    "eslint-plugin-jsx-a11y": "^6.0.3",
+    "eslint-plugin-react": "^7.9.1",
     "jest": "^23.1.0",
     "redux": "^3.7.2",
     "redux-mock-store": "^1.2.3",

ddp-redux/src/DDPClient.js

@@ -5,9 +5,7 @@ import DDPError from './DDPError';
 import Storage from './utils/Storage';
 import carefullyMapValues from './utils/carefullyMapValues';
 
-import {
-  DEFAULT_SOCKET_ID,
-} from './constants';
+import { DEFAULT_SOCKET_ID } from './constants';
 
 import * as collections from './modules/collections';
 import * as connection from './modules/connection';
@@ -220,12 +218,10 @@ class DDPClient extends DDPEmitter {
     } = properties;
     return (dispatch) => {
       dispatch(queryUpdate(queryId, null));
-      dispatch(
-        callMethod(name, params, {
-          queryId,
-          socketId,
-        }),
-      ).then((result) => {
+      dispatch(callMethod(name, params, {
+        queryId,
+        socketId,
+      })).then((result) => {
         dispatch(queryUpdate(queryId, { result }));
       }).catch((error) => {
         dispatch(queryUpdate(queryId, { error }));

ddp-redux/src/constants.js

@@ -124,40 +124,40 @@ export const MSG_CONNECTED = 'connected';
 export const MSG_FAILED = 'failed';
 
 export const MESSAGE_TO_ACTION = {
-  [MSG_READY]:        DDP_READY,
-  [MSG_NOSUB]:        DDP_NOSUB,
-  [MSG_ADDED]:        DDP_ADDED,
-  [MSG_REMOVED]:      DDP_REMOVED,
-  [MSG_CHANGED]:      DDP_CHANGED,
+  [MSG_READY]: DDP_READY,
+  [MSG_NOSUB]: DDP_NOSUB,
+  [MSG_ADDED]: DDP_ADDED,
+  [MSG_REMOVED]: DDP_REMOVED,
+  [MSG_CHANGED]: DDP_CHANGED,
   // NOTE: These two are not supported at the moment;
   //       as a fallback, we interpret "added before"
   //       as "added", so ordering will be ignored
   //       but the element will still end up in the collection.
   // [MSG_ADDED_BEFORE]: DDP_ADDED_BEFORE,
   // [MSG_MOVED_BEFORE]: DDP_MOVED_BEFORE,
   [MSG_ADDED_BEFORE]: DDP_ADDED,
-  [MSG_UPDATED]:      DDP_UPDATED,
-  [MSG_RESULT]:       DDP_RESULT,
-  [MSG_PING]:         DDP_PING,
-  [MSG_ERROR]:        DDP_ERROR,
-  [MSG_CONNECTED]:    DDP_CONNECTED,
-  [MSG_FAILED]:       DDP_FAILED,
+  [MSG_UPDATED]: DDP_UPDATED,
+  [MSG_RESULT]: DDP_RESULT,
+  [MSG_PING]: DDP_PING,
+  [MSG_ERROR]: DDP_ERROR,
+  [MSG_CONNECTED]: DDP_CONNECTED,
+  [MSG_FAILED]: DDP_FAILED,
 };
 
 export const ACTION_TO_MESSAGE = {
-  [DDP_SUB]:          MSG_SUB,
-  [DDP_UNSUB]:        MSG_UNSUB,
-  [DDP_METHOD]:       MSG_METHOD,
-  [DDP_CONNECT]:      MSG_CONNECT,
-  [DDP_PONG]:         MSG_PONG,
+  [DDP_SUB]: MSG_SUB,
+  [DDP_UNSUB]: MSG_UNSUB,
+  [DDP_METHOD]: MSG_METHOD,
+  [DDP_CONNECT]: MSG_CONNECT,
+  [DDP_PONG]: MSG_PONG,
 };
 
 export const ACTION_TO_PRIORITY = {
-  [DDP_SUB]:          10,
-  [DDP_UNSUB]:        10,
-  [DDP_METHOD]:       0,
-  [DDP_CONNECT]:      100,
-  [DDP_PONG]:         10,
+  [DDP_SUB]: 10,
+  [DDP_UNSUB]: 10,
+  [DDP_METHOD]: 0,
+  [DDP_CONNECT]: 100,
+  [DDP_PONG]: 10,
 };
 
 // NOTE: It's important that the value is smaller than DDP_CONNECT priority,

ddp-redux/src/ejson/newBinary.js

@@ -25,7 +25,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
-const newBinary = function (len) {
+function newBinary(len) {
   if (typeof Uint8Array === 'undefined' || typeof ArrayBuffer === 'undefined') {
     const ret = [];
     for (let i = 0; i < len; i += 1) {
@@ -35,6 +35,6 @@ const newBinary = function (len) {
     return ret;
   }
   return new Uint8Array(new ArrayBuffer(len));
-};
+}
 
 export default newBinary;

ddp-redux/src/ejson/tinytest.js

@@ -1,3 +1,4 @@
+/* eslint import/no-extraneous-dependencies: "off" */
 import chai from 'chai';
 
 const test = {

ddp-redux/src/index.js

@@ -1,24 +1,12 @@
 import DDPClient from './DDPClient';
 import DDPError from './DDPError';
 import EJSON from './ejson';
-import {
-  createCollectionSelectors,
-} from './modules/collections/selectors';
-import {
-  createCurrentUserSelectors,
-} from './modules/currentUser/selectors';
-import {
-  createSubscriptionsSelector,
-} from './modules/subscriptions/selectors';
-import {
-  createQueriesSelector,
-} from './modules/queries/selectors';
-import {
-  createConnectionSelector,
-} from './modules/connection/selectors';
-import {
-  createMethodsSelector,
-} from './modules/methods/selectors';
+import { createCollectionSelectors } from './modules/collections/selectors';
+import { createCurrentUserSelectors } from './modules/currentUser/selectors';
+import { createSubscriptionsSelector } from './modules/subscriptions/selectors';
+import { createQueriesSelector } from './modules/queries/selectors';
+import { createConnectionSelector } from './modules/connection/selectors';
+import { createMethodsSelector } from './modules/methods/selectors';
 import './shim';
 
 export * from './actions';

ddp-redux/src/modules/collections/middleware.test.js

@@ -2,9 +2,7 @@
 /* eslint no-invalid-this: "off" */
 
 import configureStore from 'redux-mock-store';
-import {
-  createMiddleware,
-} from './middleware';
+import { createMiddleware } from './middleware';
 import {
   DDP_FLUSH,
   DDP_READY,
@@ -14,9 +12,7 @@ import {
   DDP_CHANGED,
   DDP_REMOVED,
 } from '../../constants';
-import {
-  DDPClient,
-} from './testCommon';
+import { DDPClient } from './testCommon';
 
 jest.useFakeTimers();
 

ddp-redux/src/modules/collections/reducer.js

@@ -107,9 +107,11 @@ export const createReducer = () => (state = {}, action) => {
       });
     case DDP_QUERY_UPDATE:
       return (() => {
-        const queryId = action.meta.queryId;
-        const entities = action.payload.entities;
-        const oldEntities = action.payload.oldEntities;
+        const { queryId } = action.meta;
+        const {
+          entities,
+          oldEntities,
+        } = action.payload;
         return insertQueries(
           removeQueries(
             state,
@@ -122,8 +124,8 @@ export const createReducer = () => (state = {}, action) => {
       })();
     case DDP_QUERY_DELETE:
       return (() => {
-        const queryId = action.meta.queryId;
-        const entities = action.payload.entities;
+        const { queryId } = action.meta;
+        const { entities } = action.payload;
         return removeQueries(
           state,
           queryId,

ddp-redux/src/modules/collections/reducer.test.js

@@ -1,9 +1,7 @@
 /* eslint-env jest */
 /* eslint no-invalid-this: "off" */
 
-import {
-  createReducer,
-} from './reducer';
+import { createReducer } from './reducer';
 import {
   DDP_FLUSH,
   DDP_ADDED,
@@ -15,9 +13,7 @@ import {
   DDP_METHOD,
   DDP_UPDATED,
 } from '../../constants';
-import {
-  DDPClient,
-} from './testCommon';
+import { DDPClient } from './testCommon';
 
 describe('Test module - collections - reducer', () => {
   let testContext;
@@ -222,7 +218,7 @@ describe('Test module - collections - reducer', () => {
         },
       });
       expect(state).toEqual(testContext.referenceState1);
-    }
+    },
   );
 
   test('should add another entity', () => {

ddp-redux/src/modules/collections/selectors.js

@@ -5,9 +5,7 @@ import mapValues from 'lodash/mapValues';
 import values from 'lodash/values';
 import forEach from 'lodash/forEach';
 import map from 'lodash/map';
-import {
-  createSelector,
-} from 'reselect';
+import { createSelector } from 'reselect';
 import createValuesMappingSelector from '../../utils/createValuesMappingSelector';
 
 const identity = x => x;

ddp-redux/src/modules/collections/selectors.test.js

@@ -1,11 +1,7 @@
 /* eslint-env jest */
 
-import {
-  createSelectors,
-} from './selectors';
-import {
-  DDPClient,
-} from './testCommon';
+import { createSelectors } from './selectors';
+import { DDPClient } from './testCommon';
 
 const constant = x => () => x;
 

ddp-redux/src/modules/connection/middleware.test.js

@@ -1,9 +1,7 @@
 /* eslint-env jest */
 
 import configureStore from 'redux-mock-store';
-import {
-  createMiddleware,
-} from './middleware';
+import { createMiddleware } from './middleware';
 import {
   DEFAULT_SOCKET_ID,
 
@@ -21,9 +19,7 @@ import {
   DDP_CLOSE,
 } from '../../constants';
 // import DDPError from '../../DDPError';
-import {
-  DDPClient,
-} from './testCommon';
+import { DDPClient } from './testCommon';
 
 const createInitialState = (socketId, socketState) => ({
   ddp: {
@@ -229,7 +225,7 @@ describe('Test module - connection - middleware', () => {
         },
       ]);
       expect(testContext.ddpClient.sockets).toEqual({});
-    }
+    },
   );
 
   test('should close connection if there is only one user', () => {

ddp-redux/src/modules/connection/reducer.js

@@ -52,9 +52,9 @@ export const createReducer = (DDPClient) => {
               ...state.sockets,
               [socketId]: {
                 ...state.sockets[socketId],
-                id:       socketId,
-                users:    ((state.sockets[socketId] && state.sockets[socketId].users) || 0) + 1,
-                params:   action.payload.params,
+                id: socketId,
+                users: ((state.sockets[socketId] && state.sockets[socketId].users) || 0) + 1,
+                params: action.payload.params,
                 endpoint: action.payload.endpoint,
               },
             },

ddp-redux/src/modules/connection/reducer.test.js

@@ -1,8 +1,6 @@
 /* eslint-env jest */
 
-import {
-  createReducer,
-} from './reducer';
+import { createReducer } from './reducer';
 import {
   DDP_CONNECTION_STATE__DISCONNECTED,
   DDP_CONNECTION_STATE__CONNECTING,
@@ -14,9 +12,7 @@ import {
   DDP_OPEN,
   DDP_CLOSE,
 } from '../../constants';
-import {
-  DDPClient,
-} from './testCommon';
+import { DDPClient } from './testCommon';
 
 describe('Test module - connection - reducer', () => {
   let testContext;

ddp-redux/src/modules/connection/selectors.js

@@ -1,11 +1,7 @@
 import find from 'lodash/find';
-import {
-  createSelector,
-} from 'reselect';
+import { createSelector } from 'reselect';
 import EJSON from '../../ejson';
-import {
-  DEFAULT_SOCKET_ID,
-} from '../../constants';
+import { DEFAULT_SOCKET_ID } from '../../constants';
 
 export const createConnectionSelector = ({
   selectDeclaredConnection,

ddp-redux/src/modules/connection/testCommon.js

@@ -1,7 +1,5 @@
 import DDPEmitter from '../../DDPEmitter';
-import {
-  DEFAULT_SOCKET_ID,
-} from '../../constants';
+import { DEFAULT_SOCKET_ID } from '../../constants';
 
 export class DDPClient extends DDPEmitter {
   constructor() {