Core: CLI imporvement to show Warning message when VAULT_ADDR or -add…

…ress is not set. Resolves hashicorp#9684.
aphorise · Sep 4, 2022 · 6f3328f · 6f3328f
1 parent 700852c
commit 6f3328f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/changelog/17008.txt b/changelog/17008.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+core/cli: Warning related to VAULT_ADDR & -address not set with CLI requests.
+```
diff --git a/command/base.go b/command/base.go
@@ -333,6 +333,10 @@ func (c *BaseCommand) flagSet(bit FlagSetBit) *FlagSets {
 				addrStringVar.Default = c.flagAddress
 			} else {
 				addrStringVar.Default = "https://127.0.0.1:8200"
+				// if no VAULT_ADDR or -address provided then give warning.
+				if os.Getenv("VAULT_ADDR") == "" {
+					c.UI.Warn("WARNING: neither VAULT_ADDR nor the -address parameter is set. Defaulting to loopback address (https://127.0.0.1:8200).")
+				}
 			}
 			f.StringVar(addrStringVar)