Fix review comments

api3dao · May 13, 2024 · bfe0894 · bfe0894
1 parent bdc59dd
commit bfe0894
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/data-fetcher-loop/signed-data-state.ts b/src/data-fetcher-loop/signed-data-state.ts
@@ -46,6 +46,8 @@ export const saveSignedData = async (signedDataBatch: SignedDataRecordEntry[]) =
   if (signedDataBatch.length === 0) return;
 
   const verifier = await getVerifier();
+  // We are skipping the whole batch even if there is only one invalid signed data. This is consistent with the Signed
+  // API approach.
   const verificationResult = await verifier.verifySignedData(signedDataBatch);
   if (verificationResult !== true) {
     logger.error('Failed to verify signed data.', verificationResult);

diff --git a/src/update-feeds-loops/update-feeds-loops.ts b/src/update-feeds-loops/update-feeds-loops.ts
@@ -261,7 +261,7 @@ export const runUpdateFeeds = async (providerName: string, chain: Chain, chainId
         // Overwrite the state with the new signed API URLs instead of merging them to avoid keeping stale URLs.
         updateState((draft) => {
           set(draft, ['signedApiUrls', chainId, providerName], signedApiUrls);
-          set(draft, ['beaconIds', chainId, providerName], beaconIds);
+          set(draft, ['activeDataFeedBeaconIds', chainId, providerName], beaconIds);
         });
       });