-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Initial data fetcher and signed data store implementation #21
Conversation
method: 'get', | ||
timeout: HTTP_SIGNED_DATA_API_ATTEMPT_TIMEOUT - HTTP_SIGNED_DATA_API_HEADROOM / 2, | ||
//url: `${url}/${airnodeAddress}`, | ||
url: `${url}/0xC04575A2773Da9Cd23853A69694e02111b2c4182`, // TODO override here so we can better simulate many apis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw it while browsing the repositories the address here is not the address of the node. 0xc52EeA00154B4fF1EbbF8Ba39FDe37F1AC3B9Fd4
this is the one for Nodary Airnode address. I don't know it is intended or not so just fyi :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bdrhn9, this is just for testing, we ideally need a server that serves many airnodes with fresh data 😅
Do you have other airnode addresses on this server? Also it looks like the timestamps don't change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have other airnode addresses on this server? Also it looks like the timestamps don't change.
Yeah there is one belongs to Nodary 0xc52EeA00154B4fF1EbbF8Ba39FDe37F1AC3B9Fd4
and it is being updated freshly.
This PR adds a signed data fetcher.
I haven't written tests yet as I want to get an opinion if this approach is reasonable.
Closes #6