Temporarily disable signed data verification #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrhn9
approved these changes
May 1, 2024
Siegrift
force-pushed
the
disable-signed-data-verification
branch
from
e063779 to
5d2d57d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying signed data is a big bottleneck in Airseeker. With less chains used Airseeker should be able to handle the load - but to be sure, we might temporarily disable the signed data signature check. Note, that we only query the Nodary and API3 Signed APIs at the moment, which we can trust.
This should allow Airseeker to be much more performant until we resolve #282