Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immer state #59

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Immer state #59

merged 6 commits into from
Nov 2, 2023

Conversation

vponline
Copy link
Contributor

Closes #51

@vponline vponline requested review from Siegrift and aquarat and removed request for Siegrift October 31, 2023 12:59
@vponline vponline self-assigned this Oct 31, 2023
Siegrift
Siegrift requested changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a few unit tests for the updateState function? I am interested to see:

  • if we need the return draft (I think that return is optional).
  • whether it correctly updates immutably

src/gas-price/gas-price.test.ts Outdated Show resolved Hide resolved
Siegrift
Siegrift approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@vponline vponline merged commit 6c6e2af into main Nov 2, 2023
@vponline vponline deleted the immer-state branch November 2, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

@aquarat aquarat Awaiting requested review from aquarat

Assignees

@vponline vponline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve local state management
2 participants
@vponline @Siegrift