Only store signed data for active dapis #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquarat
changed the title
Siegrift
force-pushed
the
make-airseeker-run-locally
branch
2 times, most recently
from
34b7f76 to
a7c1141
Compare
|
I've unassigned myself from reviewer list. Per the discussion on the call the implementtion needs to change to time based cleanup after 1d. Feel free to request review again when it's fixed. |
Merged
|
Closing as replaced by #100 (due to a combination of conflicts and change in strategy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
This PR filters incoming signed data to only store signed data for active beacons.
This PR also purges data in the signed data store for which there are no active dApis.
I'm not sure if putting
getBeaconsForActiveDapisin State is a good idea 🤷