feat: reduce auth requests #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tokers
reviewed
Dec 8, 2020
| return nil, self.last_refresh_jwt_err | ||
| end | ||
|
|
||
| -- something unexpected happened, try again |
Firstsawyou
reviewed
Dec 8, 2020
lib/resty/etcd/v3.lua
Outdated
| @@ -19,6 +20,7 @@ local decode_json = cjson.decode | |||
| local encode_json = cjson.encode | |||
| local encode_base64 = ngx.encode_base64 | |||
| local decode_base64 = ngx.decode_base64 | |||
| local semaphore = require("ngx.semaphore") | |||
There was a problem hiding this comment.
It is better to align with the code format above.
tokers
approved these changes
Dec 8, 2020
membphis
approved these changes
Dec 8, 2020
|
@spacewander do we need to release a new version after we merge this PR? |
|
@membphis |
|
#104 released version 1.4.3 |
wfnuser
pushed a commit
to wfnuser/lua-resty-etcd
that referenced
this pull request
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.