Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom dns lookup #175

Merged
merged 4 commits into from
May 2, 2022
Merged

Conversation

tomkosm
Copy link
Contributor

@tomkosm tomkosm commented Nov 2, 2021

Default dns.lookup() is running on libuv threadpool and on high load or issues with the dns server it can cause increased latency in getting the initial connection.
nodejs/node#8436

In my opinion the best way to "patch" this is allow users to use their own dns lookup function.

@tomkosm
Copy link
Contributor Author

tomkosm commented Nov 2, 2021

By the way, I havent worked with typescript and couldnt figure out how to properly declare type of dnsLookup.

src/chain.ts Outdated Show resolved Hide resolved
@szmarczak szmarczak merged commit 4f3a0e6 into apify:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants