Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete a developer app without the developer id #338

Closed
srinandan opened this issue Dec 1, 2023 · 2 comments · Fixed by #339
Closed

feat: delete a developer app without the developer id #338

srinandan opened this issue Dec 1, 2023 · 2 comments · Fixed by #339
Assignees
@srinandan
Labels
enhancement New feature or request

Comments

@srinandan
Copy link
Collaborator

No description provided.

@srinandan srinandan self-assigned this Dec 1, 2023
@srinandan srinandan added the enhancement New feature or request label Dec 1, 2023
srinandan added a commit that referenced this issue Dec 1, 2023
@srinandan
feat: allow delete by app name only #338
8616326
@srinandan srinandan linked a pull request Dec 1, 2023 that will close this issue
feat: allow delete by app name only #338 #339
Merged
srinandan added a commit that referenced this issue Dec 1, 2023
@srinandan
chore: fix linting issues #338
ef6c758
@kurtkanaskie
Copy link
Collaborator

See my PR review, but this causes issues since an app name is not unique.
Multiple developers can have the same named app.
Using delete by name deletes the first app returned.

srinandan added a commit that referenced this issue Dec 4, 2023
@srinandan
bug: undo delete by appname #338
ee26840
@srinandan
Copy link
Collaborator Author

NOTE: This feature cannot be implemented. But the branch contains other features that can still go through. I have removed this feature.

srinandan added a commit that referenced this issue Dec 5, 2023
@srinandan
feat: return all apps that match name #338
ae4d723
srinandan added a commit that referenced this issue Dec 5, 2023
@srinandan
feat: allow delete by app name only #338 (#339)
42d0e76 
* feat: allow delete by app name only #338

* chore: fix linting issues #338

* bug: undo delete by appname #338

* feat: return all apps that match name #338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srinandan srinandan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow delete by app name only #338 apigee/apigeecli
2 participants
@srinandan @kurtkanaskie