Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--continue=false is ignored when used with apigeecli flowhooks attach #546

Closed
lukebrody opened this issue Sep 24, 2024 · 0 comments · Fixed by #548
Closed

--continue=false is ignored when used with apigeecli flowhooks attach #546

lukebrody opened this issue Sep 24, 2024 · 0 comments · Fixed by #548

Comments

@lukebrody
Copy link

lukebrody commented Sep 24, 2024

continueOnError is only added to the JSON if the value is true

But the default value of continueOnError is also true https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments.flowhooks#FlowHook

So, when --continue=false is passed, continueOnError is not included in the JSON, and is set to true.

srinandan added a commit that referenced this issue Sep 25, 2024
srinandan added a commit that referenced this issue Sep 25, 2024
* bug: allow setting continueOnErr to false or not at all #546

* chore: update unit tests #546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant