Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fixes print statements during export #506 #507

Merged
merged 3 commits into from
Jul 18, 2024
Merged

bug: fixes print statements during export #506 #507

merged 3 commits into from
Jul 18, 2024

Conversation

srinandan
Copy link
Collaborator

No description provided.

@srinandan srinandan requested a review from kurtkanaskie July 16, 2024 23:39
@srinandan srinandan linked an issue Jul 16, 2024 that may be closed by this pull request
org import fails while importing Apps #506
Closed
@srinandan srinandan added the bug Something isn't working label Jul 16, 2024
kurtkanaskie
kurtkanaskie requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right:
Exporting configuration for environment dev
Exporting Target servers...
Exporting Key store names...
Exporting Key alias certs...
Exporting references...
Exporting KV Map names for environment...
Exporting KVM entries for apigeex-mint-kurt in org accrual
Exporting KVM entries for apigeex-mint-kurt in org bazaarvoice
Exporting KVM entries for apigeex-mint-kurt in org error-handling-v1
Exporting KVM entries for apigeex-mint-kurt in org issue488
Exporting KVM entries for apigeex-mint-kurt in org issue488-json
Exporting KVM entries for apigeex-mint-kurt in org json
Exporting KVM entries for apigeex-mint-kurt in org json-array
Exporting KVM entries for apigeex-mint-kurt in org korean
Exporting KVM entries for apigeex-mint-kurt in org kvm-sf-test-v1-env
Exporting KVM entries for apigeex-mint-kurt in org kvm-test-multiple-keys
Exporting KVM entries for apigeex-mint-kurt in org kvm-test-v1
Exporting KVM entries for apigeex-mint-kurt in org kvm-test-v2
Exporting KVM entries for apigeex-mint-kurt in org lambda
Exporting KVM entries for apigeex-mint-kurt in org log-set-values-v1
Exporting KVM entries for apigeex-mint-kurt in org multi-value
Exporting KVM entries for apigeex-mint-kurt in org oauth-v1
Exporting KVM entries for apigeex-mint-kurt in org oauth-v1-jwt-key
Exporting KVM entries for apigeex-mint-kurt in org pingstatus-oauth-v1

@kurtkanaskie
Copy link
Collaborator

kurtkanaskie commented Jul 17, 2024 •
edited
Loading

In org/export.go line 368 maybe use:
clilog.Info.Printf("\tExporting KVM entries for %s with scope %s\n", mapName, scope)

@srinandan srinandan requested a review from kurtkanaskie July 18, 2024 02:57
kurtkanaskie
kurtkanaskie approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srinandan srinandan merged commit 3ea45ca into main Jul 18, 2024
4 checks passed
@srinandan srinandan deleted the issue506 branch July 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtkanaskie kurtkanaskie kurtkanaskie approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

org import fails while importing Apps
2 participants
@srinandan @kurtkanaskie