Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests of registry compute complexity for protos, openapi, and discovery formats #1116

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

timburks
Copy link
Contributor

@timburks timburks commented Mar 21, 2023

This verifies that the computation runs and computes something for the three formats.

testdata is identical to the testdata in the vocabulary package, these could be merged and pulled up a level if desired.

@timburks timburks requested a review from theganyo March 21, 2023 21:29
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1116 (d9b1c65) into main (df7c3b4) will increase coverage by 0.76%.
The diff coverage is 100.00%.

❗ Current head d9b1c65 differs from pull request most recent head 407d3e4. Consider uploading reports for the commit 407d3e4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
+ Coverage   69.13%   69.90%   +0.76%     
==========================================
  Files         145      145              
  Lines       12017    12022       +5     
==========================================
+ Hits         8308     8404      +96     
+ Misses       2985     2890      -95     
- Partials      724      728       +4     
Impacted Files Coverage Δ
cmd/registry/tasks/tasks.go 100.00% <100.00%> (+5.26%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timburks timburks merged commit 2e9fc58 into apigee:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants