Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github workflow for check results #1155

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Conversation

theganyo
Copy link
Member

@theganyo theganyo commented Apr 24, 2023

Fixes #1152

Example:

    services:
      local-registry:
        image: ghcr.io/apigee/registry-server:main
        env:
          REGISTRY_LOGGING_LEVEL: debug
        ports:
          - 8080:8080
    steps:
    - uses: actions/checkout@v3
    - name: Configure local Registry
      uses: apigee/registry/.github/actions/setup-registry@main
      with:
        name: local
        address: localhost:8080
        insecure: true
        version: 
        project: test
    - name: Create a project
      run: registry rpc admin create-project --project_id test
    - name: Apply an entity into the registry
      run: registry apply -f some-entity-file.yaml
    - name: Run registry check
      uses: apigee/registry/.github/actions/registry-check@main
      with:
        pattern: projects/test
        error-level: WARNING

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1155 (64af44a) into main (ef59380) will decrease coverage by 0.01%.
The diff coverage is 68.18%.

❗ Current head 64af44a differs from pull request most recent head de72766. Consider uploading reports for the commit de72766 to get more accurate results

@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
- Coverage   70.86%   70.86%   -0.01%     
==========================================
  Files         146      146              
  Lines       11973    11994      +21     
==========================================
+ Hits         8485     8499      +14     
- Misses       2772     2778       +6     
- Partials      716      717       +1     
Impacted Files Coverage Δ
cmd/registry/cmd/check/check.go 49.48% <68.18%> (+4.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@theganyo theganyo marked this pull request as ready for review April 24, 2023 22:34
@theganyo theganyo requested a review from timburks April 25, 2023 15:38
@timburks
Copy link
Contributor

This is great. I'm missing some details:

In the example in the description, how is the registry-server run?

Also, in the example I see this line:

      uses: apigee/registry/.github/actions/registry-config

Is actions/registry-config now registry-setup?

@theganyo
Copy link
Member Author

Yes, sorry, I updated the comment.

theganyo added a commit to theganyo/registry that referenced this pull request Apr 25, 2023
@theganyo theganyo merged commit f8221ae into apigee:main Apr 25, 2023
@theganyo theganyo deleted the theganyo/issue1152 branch April 25, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

define a github workflow using registry check results
2 participants