Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug flag that retains temporary files #1166

Merged
merged 2 commits into from
May 3, 2023

Conversation

theganyo
Copy link
Member

@theganyo theganyo commented May 3, 2023

Fixes #1130

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1166 (10a167d) into main (2d8c94b) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   70.80%   70.79%   -0.02%     
==========================================
  Files         146      146              
  Lines       12048    12054       +6     
==========================================
+ Hits         8531     8534       +3     
- Misses       2796     2797       +1     
- Partials      721      723       +2     
Impacted Files Coverage Δ
cmd/registry/cmd/compute/lint/lint.go 71.76% <66.66%> (-1.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@theganyo
Copy link
Member Author

theganyo commented May 3, 2023

FYI: #1130 suggested changing LinterRequest to include a debug flag, but I didn't see any reason to do so for this as the behavior to remove the directory exists at the level of the caller of LinterRequest.

@theganyo theganyo requested a review from timburks May 3, 2023 22:54
@theganyo theganyo merged commit b04c507 into apigee:main May 3, 2023
@theganyo theganyo deleted the theganyo/issue1130 branch May 3, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry tool: linter plugins should accept a debug flag that retains temporary files.
2 participants