Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add detailed help for get command #1217

Merged
merged 1 commit into from
Aug 10, 2023
Merged

add detailed help for get command #1217

merged 1 commit into from
Aug 10, 2023

Conversation

theganyo
Copy link
Member

@theganyo theganyo commented Aug 9, 2023

No description provided.

@theganyo theganyo requested a review from timburks August 9, 2023 20:54
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1217 (1a22f97) into main (74166d9) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
+ Coverage   71.86%   71.95%   +0.09%     
==========================================
  Files         146      146              
  Lines       12197    12239      +42     
==========================================
+ Hits         8765     8807      +42     
  Misses       2749     2749              
  Partials      683      683              
Files Changed Coverage Δ
cmd/registry/cmd/get/get.go 80.47% <100.00%> (+3.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@timburks timburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like the use of NAME instead of ID, preferring consistency with the YAML experience over the lower-level AIP style. It's unfortunate that they don't match, but I think the YAML conventions are more relevant.

@theganyo theganyo merged commit bce4232 into main Aug 10, 2023
@theganyo theganyo deleted the theganyo-patch-1 branch August 10, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants