Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capturing validation errors in Express/NestJS #52

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

itssimon
Copy link
Member

@itssimon itssimon commented Nov 4, 2024

No description provided.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (fb98cc5) to head (1987aaf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/express/middleware.ts 89.83% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   92.40%   91.82%   -0.58%     
==========================================
  Files          18       18              
  Lines        1711     1701      -10     
  Branches      179      182       +3     
==========================================
- Hits         1581     1562      -19     
- Misses        126      135       +9     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itssimon itssimon merged commit 7267e75 into main Nov 4, 2024
49 of 51 checks passed
@itssimon itssimon deleted the express-validation-errors-fix branch November 4, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant