Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delegation and update surface syntax #437

Merged
merged 76 commits into from
Oct 22, 2022
Merged

Implement delegation and update surface syntax #437

merged 76 commits into from
Oct 22, 2022

Conversation

s-ren
Copy link
Contributor

@s-ren s-ren commented May 31, 2022

Instead of declaring a label for each host, we now declare delegation relations between hosts. For example,

// Old syntax:
host alice : A /\ B<-
host bob : B /\ A<-

// New syntax:
host alice
host bob

assume for <- alice trusts bob
assume for <- bob trusts alice

s-ren and others added 30 commits February 28, 2022 17:02
…, nonempty_delegation_decl_list, nonempty_host_decl_list, delegation_decl, host_decl.
…, DelegationDeclarationNode, DelegationDeclarationListNode
…ameter. Updated labelExpressions, added congruence classes, and updated SecurityLattice and algebraic systems, and deleted outdated solvers because I give up trying to make it compile
s-ren and others added 15 commits October 8, 2022 20:31
* origin/master:
  Update Kiama links
  Bump mkdocs-material from 8.4.4 to 8.5.6 in /docs (#509)
  Bump Kotlin to 1.7.20 (#512)
  Bump kotlin-logging from 2.1.23 to 3.0.0 (#500)
  Bump log4j-core from 2.18.0 to 2.19.0 (#498)
  Bump log4j-slf4j-impl from 2.18.0 to 2.19.0 (#499)
  Bump log4j-core from 2.18.0 to 2.19.0 in /examples (#501)
  Bump kotlin-logging from 2.1.23 to 3.0.0 in /examples (#502)
  Bump jvm from 1.7.10 to 1.7.20 in /examples (#508)
  Bump junit-jupiter-api from 5.9.0 to 5.9.1 (#506)
  Bump log4j-slf4j-impl from 2.18.0 to 2.19.0 in /examples (#504)
  Bump mkdocs-material from 8.4.2 to 8.4.4 in /docs (#496)
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #437 (b5a03fd) into master (0918b21) will increase coverage by 0.73%.
The diff coverage is 91.72%.

@@             Coverage Diff              @@
##             master     #437      +/-   ##
============================================
+ Coverage     63.15%   63.88%   +0.73%     
+ Complexity     1239     1171      -68     
============================================
  Files           253      243      -10     
  Lines          9854    10010     +156     
  Branches       1430     1468      +38     
============================================
+ Hits           6223     6395     +172     
+ Misses         3367     3349      -18     
- Partials        264      266       +2     
Impacted Files Coverage Δ
...nell/viaduct/algebra/solver2/ConstraintSolution.kt 100.00% <ø> (ø)
...l_cornell/viaduct/backends/aby/ABYCodeGenerator.kt 67.78% <ø> (ø)
...cornell/viaduct/backends/aby/ABYProtocolFactory.kt 91.66% <ø> (ø)
...cornell/viaduct/backends/zkp/ZKPProtocolFactory.kt 94.28% <ø> (ø)
...t/errors/IntegrityChangingDeclassificationError.kt 100.00% <ø> (ø)
..._cornell/viaduct/errors/NoHostDeclarationsError.kt 100.00% <ø> (ø)
...in/io/github/apl_cornell/viaduct/syntax/Located.kt 100.00% <ø> (ø)
...n/io/github/apl_cornell/viaduct/syntax/Protocol.kt 47.50% <ø> (ø)
...b/apl_cornell/viaduct/protocols/Synchronization.kt 83.33% <ø> (ø)
...otlin/io/github/apl_cornell/viaduct/syntax/Host.kt 0.00% <ø> (ø)
... and 44 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cacay cacay marked this pull request as ready for review October 15, 2022 21:52
Copy link
Member

@cacay cacay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional changes:

  • Create specialization test
  • Viaduct source names (i.e., .via files) should be capitalized
  • Use full words in example file names (.via files. e.g., “polymorphism” instead of “poly”).

Copy link
Member

@cacay cacay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor comments.

@cacay cacay changed the title Delegation Implement delegation and update surface syntax Oct 22, 2022
@cacay cacay merged commit 561f367 into master Oct 22, 2022
@cacay cacay deleted the delegation branch October 22, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dump label inference graph before checks Function label inference is buggy
2 participants