[NO-TICKET] Removes local database #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Removes the local SQLite database
source_controlmodule--no-reloadTechnical Description
The local SQLite database was an initial attempt at performing faster loads of data however it was only partially implemented and upgrading the schema proved to be difficult. As values were only ever inputted into the database and never read, it resulted in a slower load time, and redundant code once the
ENABLE_PERSISTENCEflag was added with a default of False.A new attempt at adding persisted will be spiked in #69
closes #68 as it's not longer relevant