-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MANIFEST.in and include requirement.txt #378
Conversation
@thewchan can you please populate the pull request description for this change with details on what/why this change is being introduced? |
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage ? 18.46%
=======================================
Files ? 21
Lines ? 612
Branches ? 0
=======================================
Hits ? 113
Misses ? 499
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I'll take a look the next day to check what should be included in the At a glance, https://github.com/mgedmin/check-manifest looks like it could be useful for checking this in future - especially the pre-commit hook. As for what is missing, the long description comes from the readme so it looks like it will need to be included
|
@apoclyps this is actually a very simple PR, nothing is changed except now |
@apoclyps thanks so much, if it's possible please let me know when a new release is pushed to PyPI that includes this? My plan is to try putting this package on conda forge for broader exposure |
awesome @thewchan; do let me know how that goes 👍 I've released |
What's Changed
Include
requirement.txt
in sdist but referring it inMANIFEST.in
.Technical Description
Any specific technical detail that may provide additional context to aid code review.