Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-#70: Implemented --no-reload flag #76

Closed
wants to merge 2 commits into from

Conversation

yushao2
Copy link
Contributor

@yushao2 yushao2 commented May 4, 2021

What's Changed

closes #70 and closes #78 if merged

Technical Description

  • Added a new boolean flag --no-reload
    Usage: python cli.py dashboard --no-reload
  • Upon first render, the process terminates

image

@yushao2 yushao2 requested a review from apoclyps as a code owner May 4, 2021 02:46
@yushao2 yushao2 changed the title Feature-#70: Implemented --no-reload flag which stops after a single render if set Feature-#70: Implemented --no-reload flag May 4, 2021
@apoclyps
Copy link
Owner

apoclyps commented May 4, 2021

This morning I checked out the feature branch to run it locally. I think this is as close to the desired behaviour that we will be able to reach using the current render method. I'm going to spike another approach before deciding if we want to merge this.

The first render happens as soon as the live context manager is called - which results in a flicker of the TUI whilst waiting for Github to return all the data requested. This approach does exist correctly after the UI is updated and maintains the view. If we cannot remove the flicker, this approach is good enough for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add flag to perform a single dashboard update - render cycle
2 participants