Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self join #80

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Self join #80

wants to merge 5 commits into from

Conversation

hanshank
Copy link
Collaborator

  • Added tests to the games#update method. The last test is failing, and I just can't seem to fix it. If someone has time to have a look that would be great. We could also just leave it, comment it out and fix it later.

  • Added a functionality in games/index.html.erb where button changes to 'continue game' instead of 'join game' when the user is trying to join his own game.

Copy link
Collaborator

@mahoneyj02 mahoneyj02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to check out the last test before our meeting and see if I can figure anything out. Could it relate to the patch at the beginning of the test?

@@ -10,7 +10,7 @@
<h6 class="text-center">Opponent: <%= substring %> </h6>
<%= image_tag "image2.jpg", class: "index-resize" %>
<hr />
<% if current_user.id == single.user_id %>
<% if user_signed_in? && (current_user.id == single.user_id) %>
<div class="button">
<%= link_to "Continue game", game_path(single.id), method: :put, class: 'btn btn-info' %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably just being dense, but why are we using the method: :put code in here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants