Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spring configuration metadata #3553

Merged
merged 4 commits into from
Feb 23, 2021
Merged

add spring configuration metadata #3553

merged 4 commits into from
Feb 23, 2021

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Feb 19, 2021

spring configuration metadata let IDE developers offer contextual help and code completion as users are working with properties or yml files

the metadata Include the following keys

apollo.accesskey.secret
apollo.autoUpdateInjectedSpringProperties
apollo.meta
apollo.bootstrap.eagerLoad.enabled
apollo.bootstrap.enabled
apollo.bootstrap.namespaces
apollo.cluster
apollo.property.order.enable
app.id

nobodyiam
nobodyiam requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature looks great! There are some minor suggestions as below.

apollo-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json
"description": "apollo client app id. if it's empty apollo will only load public namespace configurations!."
}
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about adding more configuration metadata like apollo.cacheDir

apollo-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json Outdated Show resolved Hide resolved
apollo-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json Outdated Show resolved Hide resolved
apollo-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json Outdated Show resolved Hide resolved
apollo-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json Outdated Show resolved Hide resolved
@vdiskg vdiskg force-pushed the spring-configuration-metadata branch from c70f811 to c2c7354 Compare February 22, 2021 02:19
nobodyiam
nobodyiam approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 0a7b760 into apolloconfig:master Feb 23, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Mar 16, 2021
@vdiskg vdiskg deleted the spring-configuration-metadata branch April 22, 2021 16:23
@vdiskg vdiskg mentioned this pull request Aug 15, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vdiskg @nobodyiam