Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix oidc logout #3628

Merged
merged 1 commit into from
Apr 5, 2021
Merged

fix oidc logout #3628

merged 1 commit into from
Apr 5, 2021

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Apr 4, 2021

What's the purpose of this PR

fix oidc logout with context-path

Which issue(s) this PR fixes:

Fixes #3625

@codecov-io
Copy link

Codecov Report

Merging #3628 (9d848f3) into master (3de1d72) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3628      +/-   ##
============================================
+ Coverage     50.97%   50.99%   +0.01%     
- Complexity     2329     2330       +1     
============================================
  Files           449      449              
  Lines         14026    14026              
  Branches       1426     1426              
============================================
+ Hits           7150     7152       +2     
+ Misses         6389     6388       -1     
+ Partials        487      486       -1     
Impacted Files Coverage Δ Complexity Δ
...work/apollo/portal/spi/oidc/OidcLogoutHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) 24.00% <0.00%> (-1.00%)
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) 21.00% <0.00%> (+1.00%)
...rk/apollo/spring/property/SpringValueRegistry.java 88.88% <0.00%> (+5.55%) 11.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de1d72...9d848f3. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 943bbb4 into apolloconfig:master Apr 5, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone May 23, 2021
@vdiskg vdiskg deleted the fix-oidc-logout branch June 27, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username is not corrected with ocdi user's subject
3 participants