Remove unused private field 'environment' of AutoUpdateConfigChangeListener. #3755
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Codecov Report
@@ Coverage Diff @@
## master #3755 +/- ##
============================================
- Coverage 50.49% 50.41% -0.08%
+ Complexity 2396 2391 -5
============================================
Files 458 458
Lines 14472 14471 -1
Branches 1467 1467
============================================
- Hits 7308 7296 -12
- Misses 6659 6668 +9
- Partials 505 507 +2
Continue to review full report at Codecov.
|
| private final ConfigurableBeanFactory beanFactory; | ||
| private final TypeConverter typeConverter; | ||
| private final PlaceholderHelper placeholderHelper; | ||
| private final SpringValueRegistry springValueRegistry; | ||
| private final Gson gson; | ||
|
|
||
| public AutoUpdateConfigChangeListener(Environment environment, ConfigurableListableBeanFactory beanFactory){ |
There was a problem hiding this comment.
This is a public API and it resides in client module, so this is potentially a breaking change, though the users are rarely possible to use it, what do other reviewers' opinion ?
There was a problem hiding this comment.
I also agree we should be very very careful when introducing potentially breaking changes.
I checked the commit history and the environment is not used since #2173. But since this is a public class, I think it's better not to change the constructor signature.
There was a problem hiding this comment.
apollo-client has been used widely by user.
compability is important.
If users extends those classes by themself, they will meet additionally trouble when method's signture changed.
Thanks for your time on this PR.
Reference:
- 语义化版本 2.0.0
- Java开发手册（嵩山版）.pdf page 45
|
@mghio let's mark this and do the changes only when we must have breaking changes, for example, in the next major version. Thanks for the interest anyway 🙇 . |
What's the purpose of this PR
Remove unused private field 'environment' of AutoUpdateConfigChangeListener.