feat:namespace & release & rollback scrollbar #3936
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| @@ -546,6 +546,12 @@ table th { | |||
|
|
|||
| ::-webkit-scrollbar-thumb:vertical:hover { | |||
| background: rgba(255, 255, 255, 0); | |||
| }*/ | |||
|
|
|||
| .namespace-view-table-scrollbar { | |||
There was a problem hiding this comment.
we already have the Expand/Collapse button for every namespace, is it necessary to limit its height?
There was a problem hiding this comment.
Because it is troublesome to display and view the configuration under a lot of configurations.
For example, there is a namespace with a configuration of 1000 or more. When I move up and down, I sometimes scroll to a very deep place, and then go back and find that the shrink button is far away. If the height is fixed at this time, finding the shrink button will greatly reduce my scrolling operation at this time.
Thank you for your time。
There was a problem hiding this comment.
Thanks for the feedback. However I don't quite favor the idea to add the scrollbar for configuration items. Wouldn't it be better to add pagination for very long namespaces?
There was a problem hiding this comment.
Maybe adding a scrollbar is good for our users，Pagination is also a good idea，
I wonder if your future plan for this page long namespaces is about this optimization?
There was a problem hiding this comment.
Yes, pagination is in the to-do list #1261
There was a problem hiding this comment.
Maybe i can try add pagination in my company ENV，I can do something for community，I can contribute to the community。
Although I'm not a professional UI。
|
BTW, please also update the CHANGES.md. |
Codecov Report
@@ Coverage Diff @@
## master #3936 +/- ##
============================================
- Coverage 50.81% 50.77% -0.05%
+ Complexity 2468 2466 -2
============================================
Files 475 475
Lines 14608 14608
Branches 1523 1523
============================================
- Hits 7423 7417 -6
- Misses 6655 6665 +10
+ Partials 530 526 -4
Continue to review full report at Codecov.
|
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
What's the purpose of this PR
When we use the Apollo configuration, because there are too many configurations, the browser does not appear the drop-down box scroll bar when searching for the configuration. We can only scroll up and down through the mouse scroll axis.
Without a scroll bar, I don't know where the current location is. When I want to select other namespace configurations, I have to keep scrolling the mouse.
This is extremely inconvenient.
So,It is desirable to display a scroll bar and fix the height of each namespace configuration, which greatly facilitates the selection of namespace configuration and the location of the current space configuration.
Which issue(s) this PR fixes:
Fixes #3928
Brief changelog
remove ::-webkit-scrollbar css and fixed div height
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.