Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the npe issue for old version of gray release rules #4382

Merged
merged 1 commit into from
May 27, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Fix the npe issue for old version of gray release rules, e.g. [{"clientAppId":"appidA","clientIpList":["127.0.0.1"]}].

Which issue(s) this PR fixes:

Fixes #4380

Brief changelog

  • add default constructor for GrayReleaseRuleItemDTO so that clientIpList and clientLabelList will be initialized to empty set.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam force-pushed the fix-gray-release-rule-npe branch from 19a742e to d9ff4c8 Compare May 27, 2022 01:40
@nobodyiam nobodyiam force-pushed the fix-gray-release-rule-npe branch from d9ff4c8 to 9a282d3 Compare May 27, 2022 01:54
@codecov-commenter
Copy link

Codecov Report

Merging #4382 (9a282d3) into master (f929541) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4382      +/-   ##
============================================
- Coverage     53.19%   53.19%   -0.01%     
  Complexity     2674     2674              
============================================
  Files           489      489              
  Lines         15275    15277       +2     
  Branches       1580     1580              
============================================
+ Hits           8125     8126       +1     
- Misses         6595     6600       +5     
+ Partials        555      551       -4     
Impacted Files Coverage Δ
...work/apollo/common/dto/GrayReleaseRuleItemDTO.java 0.00% <0.00%> (ø)
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 89.18% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f929541...9a282d3. Read the comment docs.

@nobodyiam nobodyiam added this to the 2.0.1 milestone May 27, 2022
@nobodyiam nobodyiam requested a review from a team May 27, 2022 06:44
@Anilople Anilople merged commit cd77fd5 into apolloconfig:master May 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2022
@nobodyiam nobodyiam deleted the fix-gray-release-rule-npe branch May 28, 2022 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0 Server request Error
4 participants