Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:replace expired method #4429

Merged
merged 1 commit into from
Jun 30, 2022
Merged

refactor:replace expired method #4429

merged 1 commit into from
Jun 30, 2022

Conversation

zhangyangx
Copy link
Contributor

@zhangyangx zhangyangx commented Jun 29, 2022

Signed-off-by: yang.zhang [email protected]

What's the purpose of this PR

Replace expiration method

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: yang.zhang <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 29, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@zhangyangx
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@zhangyangx zhangyangx changed the title Replace expiration method refactor:replace replace method Jun 29, 2022
@zhangyangx zhangyangx changed the title refactor:replace replace method refactor:replace expired method Jun 29, 2022
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit ec2dabe into apolloconfig:master Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants