Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused propery ctrip.appid #4795

Merged
merged 2 commits into from
Mar 19, 2023

Conversation

hezhangjian
Copy link
Member

Brief changelog

I think it doesn't worth to write CHANGES.md for this patch.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #4795 (4e9ea66) into master (b7af5cc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4795   +/-   ##
=========================================
  Coverage     47.33%   47.33%           
  Complexity     1662     1662           
=========================================
  Files           346      346           
  Lines         10684    10684           
  Branches       1064     1064           
=========================================
  Hits           5057     5057           
  Misses         5319     5319           
  Partials        308      308           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also help to remove the ctrip.appid config in the src/main/resources/application.yml and src/test/resources/application.yml.

@hezhangjian
Copy link
Member Author

@nobodyiam Fixed

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 196c8f9 into apolloconfig:master Mar 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants