Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that the deletion failure of the system rights management page does not prompt #4803

Merged
merged 78 commits into from
Mar 17, 2023

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Mar 15, 2023

What's the purpose of this PR

Fix the problem that the deletion failure of the system rights management page does not prompt

image

klboke and others added 30 commits May 16, 2019 11:07
@klboke klboke requested a review from nobodyiam March 15, 2023 12:08
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #4803 (eae11ec) into master (670cc0e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4803   +/-   ##
=========================================
  Coverage     47.25%   47.26%           
- Complexity     1660     1661    +1     
=========================================
  Files           346      346           
  Lines         10683    10683           
  Branches       1063     1063           
=========================================
+ Hits           5048     5049    +1     
  Misses         5327     5327           
+ Partials        308      307    -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nobodyiam
Copy link
Member

There is also a toastr.warn in NamespaceRoleController.js, does it needs to be fixed?

@klboke
Copy link
Contributor Author

klboke commented Mar 16, 2023

There is also a toastr.warn in NamespaceRoleController.js, does it needs to be fixed?

Yes, it has been fixed

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit c6dfe76 into apolloconfig:master Mar 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
@klboke klboke deleted the kl-fix branch March 21, 2023 03:50
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants