Refactor the createCommit method #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4811 +/- ##
============================================
+ Coverage 47.23% 47.81% +0.58%
- Complexity 1660 1673 +13
============================================
Files 346 346
Lines 10685 10665 -20
Branches 1065 1065
============================================
+ Hits 5047 5100 +53
+ Misses 5329 5250 -79
- Partials 309 315 +6
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mghio
suggested changes
Mar 22, 2023
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/CommitService.java
Outdated
Show resolved
Hide resolved
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/CommitService.java
Show resolved
Hide resolved
...ice/src/test/java/com/ctrip/framework/apollo/adminservice/controller/ItemControllerTest.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/com/ctrip/framework/apollo/adminservice/controller/ItemControllerTest.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/com/ctrip/framework/apollo/adminservice/controller/ItemControllerTest.java
Show resolved
Hide resolved
...ice/src/test/java/com/ctrip/framework/apollo/adminservice/controller/ItemControllerTest.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/com/ctrip/framework/apollo/adminservice/controller/ItemControllerTest.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/com/ctrip/framework/apollo/adminservice/controller/ItemControllerTest.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/com/ctrip/framework/apollo/adminservice/controller/ItemControllerTest.java
Outdated
Show resolved
Hide resolved
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/ItemSetService.java
Outdated
Show resolved
Hide resolved
# Conflicts: # apollo-adminservice/src/test/java/com/ctrip/framework/apollo/adminservice/controller/ItemControllerTest.java # apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/CommitService.java # apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/ItemSetService.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Refactor the createCommit method