Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchQuery/query wrappers modify options in-place #339

Closed
sgoll opened this issue Jun 30, 2016 · 1 comment
Closed

watchQuery/query wrappers modify options in-place #339

sgoll opened this issue Jun 30, 2016 · 1 comment
Assignees
@stubailo

Comments

@sgoll
Copy link

sgoll commented Jun 30, 2016 •
edited
Loading

The watchQuery/query wrappers of ApolloClient modify the passed-in options in-place to honor the global shouldForceFetch setting: https://github.com/apollostack/apollo-client/blob/master/src/index.ts#L119

This has the unexpected side-effect of forcing re-evaluation of queries in react-apollo as the options now don't match that of the original query.

See the original issue at apollographql/react-apollo#90 for detailed discussion.
stubailo pushed a commit that referenced this issue Jun 30, 2016
Don't mutate options
872f60b 
Fixes #339
@stubailo stubailo mentioned this issue Jun 30, 2016
Merged
4 tasks
@zol zol removed the in progress label Jun 30, 2016
@stubailo
Copy link
Contributor

Fixed in release 0.3.25!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stubailo stubailo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zol @stubailo @sgoll