-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for QueryManager continuing to poll after refetch (see issue #239) #242
Conversation
Thanks very much! |
Im down to solve this one if @ciwolsey doesn't want to |
Added a fix that greens the test too but I'm definitely not sure I've done it in the best way. |
@@ -220,13 +220,6 @@ export class QueryManager { | |||
this.stopQuery(queryId); | |||
}, | |||
refetch: (variables: any): Promise<GraphQLResult> => { | |||
// if we are refetching, we clear out the polling interval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem we're trying to fix here is that calling refetch
currently kills polling completely, but that's not the intended outcome - ideally the client will keep polling after the forced refetch.
@ciwolsey I think this does what we need, but the linter checks are not passing. Can you look into that? |
@ciwolsey Any update on this? It seems the only thing that you'd have to fix is this:
|
@helfer Fixed the if statement |
@ciwolsey Thanks a lot! Could you do a rebase as well? We've merged some other PRs into master since you made this one. |
Merged! Thanks a lot! |
Clarifies the Apollo Meteor docs
Test regarding issue #239. Hope this is okay.