Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation change] Passing credentials in opts:{} is incorrect #2462

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Conversation

alexboots
Copy link
Contributor

@alexboots alexboots commented Nov 2, 2017

Opened this issue (#2443) a couple days ago, decided to look through the code today to see if I could fix it, turned out to be a simple docs error:

credentials should not be nested inside opts, this does not work. It needs to be on the top level of the object.

Opened issue a couple days ago, looked at code today to see if I could fix, turned out to be a simple docs error:
#2443

`credentials` should not be nested inside `opts`, this does not work. It needs to be on the top level of the object.
@apollo-cla
Copy link

@alexboots: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@alexboots alexboots changed the title Passing credentials in opts:{} is incorrect [Documentation change] Passing credentials in opts:{} is incorrect Nov 2, 2017
@jbaxleyiii
Copy link
Contributor

Deploy preview ready!

Built with commit 4ca2a73

https://deploy-preview-2462--apollo-client-docs.netlify.com

@apollo-cla
Copy link

Messages
📖

Please add your name and email to the AUTHORS file (optional)

Generated by 🚫 dangerJS

@jbaxleyiii jbaxleyiii merged commit f5f7328 into apollographql:master Nov 6, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants