Remove unused queryId after fetchMore #4440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2286 (and #3901)
Every call of
fetchMore
onObservableQuery
causes another query to be created my queryManager. After this query gets executed, its result is merged into parent query's result. But child query is not disposed, it just sticks around inqueryManager.queries
/queryManager.queryStore
and does nothing. As far as I understand, this is a leak, and this query should be disposed.Please correct me if this is desired behavior, or if this change can produced any unexpected side-effects.
Checklist: