Assume keyArgs:false only if *both* read and merge provided. #5862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5680.
Assuming
keyArgs:false
just because amerge
function (or aread
function) was defined means that the following pattern can actually change cache behavior in surprising ways:Although this
merge
function mirrors how the cache behaves without amerge
function, it has the benefit of making that behavior explicit, thereby silencing the warnings introduced by #5833. In order to recommend this strategy for silencing warnings when a last-write-wins merge strategy is desired, it seems unacceptable for this pattern to have any unexpected consequences beyond silencing the warnings.Thinking about this default
keyArgs:false
behavior more, disabling field identity withkeyArgs:false
doesn't really make sense if you have only amerge
function, or only aread
function, since any fancy argument handling done by one of those functions cannot be balanced in the other direction.