Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the error passing situation with query merging #589

Merged
merged 2 commits into from
Aug 30, 2016
Merged

Fixed the error passing situation with query merging #589

merged 2 commits into from
Aug 30, 2016

Conversation

Poincare
Copy link
Contributor

@Poincare Poincare commented Aug 26, 2016 •
edited
Loading

Fixes #551. Would be great if @jmiazga could confirm whether this PR works.

Tested and works correctly on GitHunt.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)

@stubailo stubailo force-pushed the query_merging_errors branch from 94a8c60 to b1d298d Compare August 30, 2016 22:21
@stubailo stubailo merged commit 09c2e21 into master Aug 30, 2016
@stubailo stubailo removed the ready label Aug 30, 2016
@stubailo stubailo deleted the query_merging_errors branch September 20, 2016 03:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@stubailo stubailo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Poincare @stubailo