Avoid adding QueryPromise when skip is true on SSR #7310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@izumin5210: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Signed ✅ |
benjamn
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
@izumin5210 This makes sense to me, and thanks for adding a regression test. Sorry to keep you waiting!
benjamn
force-pushed
the
izumin5210/see-skip-option-on-ssr
branch
from
eaa2886 to
4b9145a
Compare
rgrove
added a commit
to rgrove/apollo-client
that referenced
this pull request
Jan 11, 2021
PR apollographql#7310 introduced a regression that caused skipped SSR queries to always set `loading` to `true`, which doesn't match the behavior of `useQuery()` on the client and can result in hydration mismatches. The problem is that `skip: true` was being treated as equivalent to `ssr: false`, but they're not actually equivalent. I think the correct solution is to let `this.getQueryResult()` provide a suitable result when `skip` is truthy, which ensures that skipped SSR queries will get the same result as skipped non-SSR queries. Fixes apollographql#7380
2 tasks
benjamn
added a commit
that referenced
this pull request
Jan 14, 2021
PR #7310 introduced a regression that caused skipped SSR queries to always set `loading` to `true`, which doesn't match the behavior of `useQuery()` on the client and can result in hydration mismatches. The problem is that `skip: true` was being treated as equivalent to `ssr: false`, but they're not actually equivalent. I think the correct solution is to let `this.getQueryResult()` provide a suitable result when `skip` is truthy, which ensures that skipped SSR queries will get the same result as skipped non-SSR queries. Fixes #7380 Co-authored-by: Ben Newman <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #6342
When
skipis set to true on SSR,useQueryskips a network request. But firingrenderToString.Checklist:
only small bugfix