Fix #713

[antmdvs]

TODO:

• If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass
• Update CHANGELOG.md with your change
• Add your name and email to the AUTHORS file (optional)
• If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

Moved @types packages from devDependencies to dependencies per #713

[apollo-cla]

@antmdvs: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[poloagustin]

I hope this gets merged soon. I'm stuck with these referenced issues 😔

[helfer]

It seems we're between a rock and a hard place here, because adding typings to dependencies makes it impossible to install Apollo Client for people who are behind a firewall and only have access to a restricted set of packages... I'm honestly not sure what the best solution is here.

[poloagustin]

@helfer Sorry, I totally missed that you are explicitly saying you use Typescript in your project. What if we add a Troubleshoot section for now that specifies the @types dependencies for typescript projects.
I also feel that the @types dependencies shouldn't compromise non-Typescript projects.

[helfer]

@poloagustin yeah, I think it would be a great idea to add a "troubleshoot" section to the README. Can you make a PR for that? 🙂

[poloagustin]

sure! 👍

[stubailo]

So should we close this then? And just document the set of types people need to add?

[tuurbo]

There are a lot of types to maintain. Could we have a seperate package, something like apollostack/apollo-client-types or maybe combine them with @types/apollo-client instead of documenting what should be used. Idk how it works, just ideas.

[stubailo]

@tuurbo how do we publish @types/apollo-client? Do we have to go talk to someone to get access to that package name?

[tuurbo]

@stubailo I found the docs https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

[DxCx]

hi @helfer, what about state @types as optionalDependcies.
this was non-typescript users don't need to install them,

[helfer]

@DxCx yeah, maybe that would be a workable solution for now!

[poloagustin]

like this #772 ?

[helfer]

Closing this now, since we merged #772. Let's see where it gets us.