Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note breaking change of network interface #798

Closed
wants to merge 1 commit into from
Closed

Conversation

stubailo
Copy link
Contributor

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@stubailo
Copy link
Contributor Author

@helfer do we actually want to make this change? It doesn't seem to really improve much, just seems like a breaking change for the sake of it. Perhaps we can keep backcompat and print a warning, then remove it in 1.0?

@helfer
Copy link
Contributor

helfer commented Oct 18, 2016

@stubailo I made the change because there was a comment in the code that said we were just doing that for backcompat. I think now is as good a time as any to make that breaking change, but I'm not dead set on it, if you want to undo it.

@stubailo
Copy link
Contributor Author

I guess we never documented the new way and it's really easy to not break it - so maybe let's put it back?

@stubailo
Copy link
Contributor Author

Closing in favor of #828

@stubailo stubailo closed this Oct 23, 2016
@stubailo stubailo deleted the stubailo-patch-2 branch January 5, 2017 06:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants