Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for rollup circular dependencies. #900

Closed
wants to merge 2 commits into from

Conversation

voodooattack
Copy link

@voodooattack voodooattack commented Nov 12, 2016

Issue for reference #731

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@apollo-cla
Copy link

@voodooattack: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@voodooattack
Copy link
Author

Signed!

@voodooattack voodooattack force-pushed the master branch 2 times, most recently from 37be9a8 to 317bea8 Compare November 12, 2016 19:14
@voodooattack voodooattack changed the title Failing test case for rollup circular dependencies. Test case for rollup circular dependencies. Nov 12, 2016
@helfer
Copy link
Contributor

helfer commented Nov 15, 2016

@voodooattack Thanks! Do you know if the dependency between ApolloClient.ts, QueryManager.ts and ObservableQuery.ts are the only ones?

I honestly think that this is something that rollup should fix, because circular dependencies are a well-known and pretty normal thing in ES6, but if there's something simple we can do to make it work in the meantime, I'm happy to go along with it 🙂

@voodooattack
Copy link
Author

@helfer I have no idea, I switched to webpack 2 beta yesterday (which also has tree-shaking) and the problem disappeared altogether. I think rollup needs to fix this though. I'm migrating over two dozen packages to webpack right now and it's not pretty.

@helfer
Copy link
Contributor

helfer commented Nov 15, 2016

@voodooattack if you no longer need this, can we close the PR?

@voodooattack
Copy link
Author

Yes, sorry. Closing it now.

@stubailo
Copy link
Contributor

@helfer I think the related issue is that we don't publish the ES2015 module build, so rollup users need to use the common js plugin which doesn't support circular deps.

@helfer
Copy link
Contributor

helfer commented Nov 16, 2016

@stubailo so what's the solution? Remove all circular dependencies? That's going to be quite tricky I think. And as you mentioned in #731, people need to use the commonjs plugin anyway if we depend on modules that are not ES6.

I think it's fine to have the test here, but until we have a solution, I'd rather keep it closed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants