-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test case for rollup circular dependencies. #900
Conversation
@voodooattack: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Signed! |
37be9a8
to
317bea8
Compare
@voodooattack Thanks! Do you know if the dependency between ApolloClient.ts, QueryManager.ts and ObservableQuery.ts are the only ones? I honestly think that this is something that rollup should fix, because circular dependencies are a well-known and pretty normal thing in ES6, but if there's something simple we can do to make it work in the meantime, I'm happy to go along with it 🙂 |
@helfer I have no idea, I switched to webpack 2 beta yesterday (which also has tree-shaking) and the problem disappeared altogether. I think rollup needs to fix this though. I'm migrating over two dozen packages to webpack right now and it's not pretty. |
@voodooattack if you no longer need this, can we close the PR? |
Yes, sorry. Closing it now. |
@helfer I think the related issue is that we don't publish the ES2015 module build, so rollup users need to use the common js plugin which doesn't support circular deps. |
@stubailo so what's the solution? Remove all circular dependencies? That's going to be quite tricky I think. And as you mentioned in #731, people need to use the commonjs plugin anyway if we depend on modules that are not ES6. I think it's fine to have the test here, but until we have a solution, I'd rather keep it closed. |
Issue for reference #731
TODO: