Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added export for NetworkInterface and HTTPFetchNetworkInterface #969

Merged
merged 3 commits into from
Nov 29, 2016
Merged

Added export for NetworkInterface and HTTPFetchNetworkInterface #969

merged 3 commits into from
Nov 29, 2016

Conversation

Poincare
Copy link
Contributor

Fixes #959.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@helfer helfer merged commit de4a542 into master Nov 29, 2016
@helfer helfer deleted the export_network_interface branch November 29, 2016 21:06
@helfer helfer removed the ready label Nov 29, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Poincare @helfer